Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add payload property to the IndividualConfig Interface #904

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

bdebon
Copy link
Contributor

@bdebon bdebon commented Oct 25, 2021

This added property on IndividualConfig allows us to pass some extra data to our custom toastComponent (like a theme, or an extra cta label or anything)

At first I wanted to dig something like it is described here:
#878

But I found the payload workaround much more easier to code and use.

@bdebon bdebon changed the title Adding a payload property in the IndividualConfig Adding a payload property in the IndividualConfig Interface Oct 25, 2021
@scttcper
Copy link
Owner

scttcper commented Oct 25, 2021

i'm 50% sure something like this already exists

Edit: guess not?

@scttcper scttcper changed the title Adding a payload property in the IndividualConfig Interface fix: Adding a payload property in the IndividualConfig Interface Oct 25, 2021
@scttcper scttcper changed the title fix: Adding a payload property in the IndividualConfig Interface fix: Add payload property to the IndividualConfig Interface Oct 25, 2021
@scttcper scttcper merged commit 2b8fe58 into scttcper:master Oct 25, 2021
@scttcper
Copy link
Owner

🎉 This PR is included in version 14.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bdebon
Copy link
Contributor Author

bdebon commented Oct 25, 2021

@scttcper... you are maybe not gonna believe it but this is my first ever pr... I'm super happy about it ahah!
Have a good night sir and thank you for this amazing plugin! I could make a pretty dope notification center thanks to it!
Enregistrement de l’écran 2021-10-25 à 16 20 57

@scttcper
Copy link
Owner

Nice job looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants